Add search filters to demo timelines #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yep-tf2
changed the title
Was intended for use to toggle regexes in chat search, but regex-only search is fine for now
Frees up vertical space Add filtering for airshots and captures Support filtering captures by player
Narcha
force-pushed
the
tauri_searchable-timeline
branch
from
e8f3d2d
to
6329805
Compare
Invalid regexes would previously break the entire page, and regex search is probably not needed anyway.
|
This is a really cool feature, thanks a lot for contributing! And apologies for taking so long to merge it 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
TODO:
Make search pane expandable to reduce used space (or, maybe shift it to the side of the timeline?)OBEMake toggle switches not take up so much vertical spaceOBECode cleanup passOBEVideo demo
searchable_timeline-2023-01-20_01.44.41.mp4