Tests & encoding fixing

[thomas-lab]

Python 2 encoding issues are a living hell. Tried to do the best out of it, and it works well! 🙃
Thanks @ebreton for detecting these issues again!

& bumped the version number

[ebreton]

@ThmsLa you are more than welcome !

My pull request was pending in the air and started to rot a bit (some conflicts emerged). I therefore merged it, and that generated some conflicts in your branch which I also try to resolve.

Some tests are failing (among them mapzen which we has nothing to do with your PR)... I will have a look at it tomorrow. Bedtime here :)

[ebreton]

Hi @ThmsLa ,

Please look at #343 for a few suggestions on refactoring (you have address somethings in your PR already).

Withor without my suggestions, the objective is to make the bing tests pass 😎

[thomas-lab]

Thanks @ebreton!
Sorry I messed up your tests with my old commits. Bing tests are now running fine.

The MapQuest test failing seems to be linked to some strange API key error. MapZen's have an SSL error, I guess we can't do much about it.

[thomas-lab]

Regarding the MapQuest test, it seems linked to paid API keys having errors issues sometimes: https://developer.mapquest.com/forum/paid-key-intermittent-403-error-not-valid-key

... and these tests work with my free key locally. Have you tried using another key? :)

[DenisCarriere]

@ThmsLa Not too sure if this PR is relevant anymore?

[thomas-lab]

@DenisCarriere I'll check next Monday, but a few things might be relevant, especially regarding the tests. Thanks for the invitation btw! :)

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@34560a1). Click here to learn what that means.
The diff coverage is 59.45%.

@@            Coverage Diff            @@
##             master     #342   +/-   ##
=========================================
  Coverage          ?   84.97%           
=========================================
  Files             ?       66           
  Lines             ?     3728           
  Branches          ?        0           
=========================================
  Hits              ?     3168           
  Misses            ?      560           
  Partials          ?        0

Impacted Files	Coverage Δ
geocoder/google.py	76.86% <0%> (ø)
geocoder/mapzen.py	62.5% <100%> (ø)
geocoder/mapquest_batch.py	95.45% <100%> (ø)
geocoder/bing_batch_reverse.py	63.79% <37.5%> (ø)
geocoder/bing_batch.py	76.08% <75%> (ø)
geocoder/bing_batch_forward.py	82.6% <75.75%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34560a1...258246e. Read the comment docs.

[thomas-lab]

@ebreton @DenisCarriere Since MapZen is shutting down, I marked the MapZen class as deprecated and updated the tests accordingly.
Seems better than removing all the MapZen related files, as users using it will get a relevant exception from it. If you're fine with it I'll merge :)

[DenisCarriere]

👍 Nice! Agreed, we can keep Mapzen but define it as deprecated 😢

Amazing, the first PR that has passing tests ✅ 🚀