Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToTestTests.cs:274-276: Make TheSameObjectDetection test... #12

Closed
0pdd opened this issue Aug 26, 2022 · 6 comments · Fixed by #27
Closed

ToTestTests.cs:274-276: Make TheSameObjectDetection test... #12

0pdd opened this issue Aug 26, 2022 · 6 comments · Fixed by #27
Assignees
@dzhukovski
Labels
lead this mark means that the task can be assigned to lead role

Comments

@0pdd
Copy link

0pdd commented Aug 26, 2022

The puzzle 60m-ac170357 from #60m has to be resolved:

ObjectToTest/tests/ObjectToTest.UnitTests/ToTestTests.cs

Lines 274 to 276 in 213e07f

* @todo #:60m/DEV Make TheSameObjectDetection test to be green.
* Now the same object detection is not implemented. It would
* be nice to fix the issue.

The puzzle was created by @DenisZhukovski on 26-Aug-22.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Aug 26, 2022
@DenisZhukovski @dzhukovski
Add puzzles and tests for circular reference detection and the same o…
213e07f 
…bject detection. (#10)

Co-authored-by: Denis Zhukovski <dzhukovsky@softek.by>
Co-authored-by: dzhukovski <69575528+dzhukovski@users.noreply.github.com>
@dzhukovski dzhukovski self-assigned this Aug 27, 2022
This was referenced Sep 5, 2022
Closed
Closed
@0pdd
Copy link
Author

0pdd commented Sep 5, 2022

@0pdd 2 puzzles #18, #19 are still not solved.

@DenisZhukovski DenisZhukovski added the lead this mark means that the task can be assigned to lead role label Sep 5, 2022
This was referenced Sep 5, 2022
Closed
Closed
Closed
@0pdd
Copy link
Author

0pdd commented Sep 5, 2022

@0pdd 4 puzzles #18, #21, #22, #23 are still not solved; solved: #19.

dzhukovski pushed a commit that referenced this issue Sep 6, 2022
@DenisZhukovski
improve the unit test
cfdd356 
@todo #12:60m/DEV Improve the test: Ideally the test should compare the result that returned by Argument method
 with some manually created argument that wraps the original object.
@0pdd 0pdd mentioned this issue Sep 6, 2022
Closed
@0pdd
Copy link
Author

0pdd commented Sep 6, 2022

@0pdd 3 puzzles #18, #21, #25 are still not solved; solved: #19, #22, #23.

@DenisZhukovski DenisZhukovski mentioned this issue Sep 6, 2022
Merged
DenisZhukovski added a commit that referenced this issue Sep 6, 2022
@DenisZhukovski
improve the unit test (#26)
513b4a5 
@todo #12:60m/DEV Improve the test: Ideally the test should compare the result that returned by Argument method
 with some manually created argument that wraps the original object.
@0pdd
Copy link
Author

0pdd commented Sep 6, 2022

@0pdd 2 puzzles #21, #25 are still not solved; solved: #18, #19, #22, #23.

@DenisZhukovski DenisZhukovski linked a pull request Sep 6, 2022 that will close this issue
fix the unit test TheSameObjectDetection #27
Merged
0pdd referenced this issue Sep 7, 2022
@DenisZhukovski
fix the unit test TheSameObjectDetection (#27)
b67b639 
* fix the unit test TheSameObjectDetection

* remove the puzzle
@0pdd
Copy link
Author

0pdd commented Sep 11, 2022

@0pdd the puzzle #21 is still not solved; solved: #18, #19, #22, #23, #25.

@0pdd
Copy link
Author

0pdd commented Sep 17, 2022

@0pdd all 6 puzzles are solved here: #18, #19, #21, #22, #23, #25.

@0pdd 0pdd mentioned this issue Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzhukovski dzhukovski

Labels
lead this mark means that the task can be assigned to lead role
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the unit test TheSameObjectDetection DenisZhukovski/ObjectToTest
3 participants
@0pdd @DenisZhukovski @dzhukovski