Deprecate give/take money, add synonyms to element math

DenizenScript · Aug 30, 2021 · a31b619 · a31b619
1 parent b1239a5
commit a31b619
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/main/java/com/denizenscript/denizencore/objects/core/ElementTag.java b/src/main/java/com/denizenscript/denizencore/objects/core/ElementTag.java
@@ -1714,6 +1714,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.abs>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.absolute_value
         // @group math
         // @description
         // Returns the absolute value of the element.
@@ -1729,6 +1730,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.max[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.larger,ElementTag.greater,ElementTag.higher,ElementTag.bigger,ElementTag.maximum
         // @group math
         // @description
         // Returns the higher number: this element or the specified one.
@@ -1744,6 +1746,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.min[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.smaller,ElementTag.lesser,ElementTag.lower,ElementTag.minimum
         // @group math
         // @description
         // Returns the lower number: this element or the specified one.
@@ -1823,6 +1826,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.add[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.plus,ElementTag.addition,ElementTag.+
         // @group math
         // @description
         // Returns the element plus a number.
@@ -1849,6 +1853,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.div[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.divide,ElementTag./
         // @group math
         // @description
         // Returns the element divided by a number.
@@ -1875,6 +1880,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.mod[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.modulo,ElementTag.modulus,ElementTag.remainder/ElementTag.%
         // @group math
         // @description
         // Returns the remainder of the element divided by a number.
@@ -1896,6 +1902,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.mul[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.multiply,ElementTag.times,ElementTag.*
         // @group math
         // @description
         // Returns the element multiplied by a number.
@@ -1922,6 +1929,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.sub[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.subtract,ElementTag.-
         // @group math
         // @description
         // Returns the element minus a number.
@@ -1948,6 +1956,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.sqrt>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.square_root
         // @group math
         // @description
         // Returns the square root of the element.
@@ -1967,6 +1976,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.log[<#.#>]>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.logarithm
         // @group math
         // @description
         // Returns the logarithm of the element, with the base of the specified number.
@@ -1986,6 +1996,7 @@ else if (CoreUtilities.toLowerCase(element).contains(CoreUtilities.toLowerCase(c
         // <--[tag]
         // @attribute <ElementTag.ln>
         // @returns ElementTag(Decimal)
+        // @synonyms ElementTag.natural_logarithm
         // @group math
         // @description
         // Returns the natural logarithm of the element.

diff --git a/src/main/java/com/denizenscript/denizencore/utilities/Deprecations.java b/src/main/java/com/denizenscript/denizencore/utilities/Deprecations.java
@@ -282,6 +282,9 @@ public class Deprecations {
     public static Warning inventoryNonMatcherTags = new FutureWarning("The 'InventoryTag' tags 'contains', 'quantity', 'find', 'exclude' with raw items are deprecated and replaced by 'contains_item', 'quantity_item', 'find_item', 'exclude_item' that use advanced matcher logic.");
     public static Warning takeRawItems = new FutureWarning("The 'take' command's ability to remove raw items without any command prefix, and the 'material' and 'scriptname' options are deprecated: use the 'item:<matcher>' option.");
 
+    // In Bukkit impl, Added 2021/08/30, deprecate officially by 2023.
+    public static Warning giveTakeMoney = new FutureWarning("The 'take' and 'give' commands option for 'money' are deprecated in favor of using the 'money' command.");
+
     // ==================== PAST deprecations of things that are already gone but still have a warning left behind ====================
 
     // In Bukkit impl, Added on 2019/10/13