Skip to content

Commit

Permalink
RedisCommand: impl in separate subclass to avoid load exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
@mcmonkey4eva
mcmonkey4eva committed Aug 29, 2022
1 parent c059bab commit c7ac457
Show file tree
Hide file tree
Showing 2 changed files with 348 additions and 323 deletions.
330 changes: 7 additions & 323 deletions src/main/java/com/denizenscript/denizencore/scripts/commands/core/RedisCommand.java
View file
@@ -1,29 +1,15 @@
package com.denizenscript.denizencore.scripts.commands.core;

import com.denizenscript.denizencore.exceptions.InvalidArgumentsException;
import com.denizenscript.denizencore.exceptions.InvalidArgumentsRuntimeException;
import com.denizenscript.denizencore.objects.Argument;
import com.denizenscript.denizencore.objects.ArgumentHelper;
import com.denizenscript.denizencore.objects.ObjectTag;
import com.denizenscript.denizencore.objects.core.ListTag;
import com.denizenscript.denizencore.objects.core.SecretTag;
import com.denizenscript.denizencore.scripts.commands.AbstractCommand;
import com.denizenscript.denizencore.scripts.commands.Holdable;
import com.denizenscript.denizencore.utilities.CoreConfiguration;
import com.denizenscript.denizencore.utilities.CoreUtilities;
import com.denizenscript.denizencore.utilities.DenizenJedisPubSub;
import com.denizenscript.denizencore.utilities.RedisHelper;
import com.denizenscript.denizencore.utilities.debugging.Debug;
import com.denizenscript.denizencore.utilities.scheduling.AsyncSchedulable;
import com.denizenscript.denizencore.utilities.scheduling.OneTimeSchedulable;
import com.denizenscript.denizencore.DenizenCore;
import com.denizenscript.denizencore.objects.core.ElementTag;
import com.denizenscript.denizencore.scripts.ScriptEntry;
import redis.clients.jedis.Jedis;
import redis.clients.jedis.JedisPubSub;
import redis.clients.jedis.util.SafeEncoder;

import java.util.*;
import java.util.concurrent.atomic.AtomicBoolean;

public class RedisCommand extends AbstractCommand implements Holdable {

Expand All @@ -34,7 +20,6 @@ public RedisCommand() {
isProcedural = false;
setPrefixesHandled("auth", "port", "id", "message", "args");
setBooleansHandled("ssl");
isEnabled.set(true);
}

// <--[command]
Expand Down Expand Up @@ -140,34 +125,15 @@ public RedisCommand() {
// - redis id:name disconnect
// -->

public static Map<String, Jedis> connections = new HashMap<>();
public static Map<String, JedisPubSub> subscriptions = new HashMap<>();

public static AtomicBoolean isEnabled = new AtomicBoolean(true);

@Override
public void onDisable() {
isEnabled.set(false);
for (Map.Entry<String, JedisPubSub> entry : subscriptions.entrySet()) {
try {
entry.getValue().punsubscribe();
}
catch (Exception e) {
Debug.echoError(e);
}
if (everUsed) {
RedisHelper.onDisable();
}
subscriptions.clear();
for (Map.Entry<String, Jedis> entry : connections.entrySet()) {
try {
entry.getValue().close();
}
catch (Exception e) {
Debug.echoError(e);
}
}
connections.clear();
}

public static volatile boolean everUsed = false;

@Override
public void parseArgs(ScriptEntry scriptEntry) throws InvalidArgumentsException {
for (Argument arg : scriptEntry) {
Expand Down Expand Up @@ -208,295 +174,13 @@ else if (!scriptEntry.hasObject("action")
}
}

public ObjectTag processResponse(Object response) {
if (response instanceof List) {
ListTag list = new ListTag();
for (Object o : (List) response) {
ObjectTag resp = processResponse(o);
if (resp == null) {
resp = new ElementTag("null");
}
list.addObject(resp);
}
return list;
}
else if (response instanceof byte[]) {
return new ElementTag(new String((byte[]) response));
}
else if (response instanceof Long) {
return new ElementTag((long) response);
}
else {
return null;
}
}

public static void runChecked(Runnable r, ScriptEntry scriptEntry) {
DenizenCore.schedule(new AsyncSchedulable(new OneTimeSchedulable(() -> {
try {
r.run();
}
catch (Throwable ex) {
if (isEnabled.get() || CoreConfiguration.debugVerbose) { // Ignore errors when server is shutting down
DenizenCore.schedule(new OneTimeSchedulable(() -> {
Debug.echoError(ex);
scriptEntry.setFinished(true);
}, 0));
}
}
}, 0)));
}

@Override
public void execute(final ScriptEntry scriptEntry) {
if (!CoreConfiguration.allowRedis) {
Debug.echoError(scriptEntry, "Redis disabled by config!");
return;
}
ElementTag port = scriptEntry.argForPrefixAsElement("port", "6379");
if (!port.isInt()) {
throw new InvalidArgumentsRuntimeException("Port must be an integer number.");
}
ElementTag id = scriptEntry.requiredArgForPrefixAsElement("id");
ElementTag message = scriptEntry.argForPrefixAsElement("message", null);
ListTag args = scriptEntry.argForPrefix("args", ListTag.class, true);
boolean ssl = scriptEntry.argAsBoolean("ssl");
ObjectTag auth = scriptEntry.argForPrefix("auth", ObjectTag.class, true);
ElementTag action = scriptEntry.getElement("action");
ElementTag host = scriptEntry.getElement("host");
ListTag channels = scriptEntry.getObjectTag("channels");
ElementTag channel = scriptEntry.getElement("channel");
ElementTag command = scriptEntry.getElement("command");
String redisID = id.asLowerString();
if (scriptEntry.dbCallShouldDebug()) {
Debug.report(scriptEntry, getName(), id, action, host, auth, port, db("ssl", ssl), channels, channel, message, command, args);
}
if (!action.asString().equalsIgnoreCase("connect") &&
(!action.asString().equalsIgnoreCase("command") || !scriptEntry.shouldWaitFor())) {
scriptEntry.setFinished(true);
}
try {
if (action.asString().equalsIgnoreCase("connect")) {
if (host == null) {
Debug.echoError(scriptEntry, "Must specify a valid redis host!");
scriptEntry.setFinished(true);
return;
}
if (connections.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Already connected to a server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
runChecked(() -> {
Jedis con = null;
if (CoreConfiguration.debugVerbose) {
Debug.echoDebug(scriptEntry, "Connecting to " + host + " on port " + port);
}
try {
con = new Jedis(host.asString(), port.asInt(), ssl);
if (auth != null) {
String[] redisArgs = new String[] { auth.shouldBeType(SecretTag.class) ? auth.asType(SecretTag.class, scriptEntry.context).getValue() : auth.toString() };
if (redisArgs[0] == null) {
throw new Exception("Invalid SecretTag input for AUTH.");
}
con.sendCommand(() -> SafeEncoder.encode("AUTH"), redisArgs);
}
}
catch (final Exception e) {
DenizenCore.schedule(new OneTimeSchedulable(() -> {
Debug.echoError(scriptEntry, "Redis Exception: " + e.getMessage());
scriptEntry.setFinished(true);
if (CoreConfiguration.debugVerbose) {
Debug.echoError(scriptEntry, e);
}
}, 0));
}
if (CoreConfiguration.debugVerbose) {
Debug.echoDebug(scriptEntry, "Connection did not error");
}
final Jedis conn = con;
if (con != null) {
DenizenCore.schedule(new OneTimeSchedulable(() -> {
connections.put(redisID, conn);
Debug.echoDebug(scriptEntry, "Successfully connected to " + host + " on port " + port);
scriptEntry.setFinished(true);
}, 0));
}
else {
DenizenCore.schedule(new OneTimeSchedulable(() -> {
scriptEntry.setFinished(true);
if (CoreConfiguration.debugVerbose) {
Debug.echoDebug(scriptEntry, "Connecting errored!");
}
}, 0));
}
}, scriptEntry);
}
else if (action.asString().equalsIgnoreCase("disconnect")) {
scriptEntry.setFinished(true);
if (!connections.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Not connected to redis server with ID '" + redisID + "'!");
return;
}
Jedis con = connections.remove(redisID);
JedisPubSub pubSub = subscriptions.remove(redisID);
if (pubSub != null) {
try {
// TODO: Make this work better?
pubSub.punsubscribe();
}
catch (Exception e) {
Debug.echoError(e);
}
}
try {
con.close();
}
catch (Exception e) {
Debug.echoError(e);
}
Debug.echoDebug(scriptEntry, "Disconnected from '" + redisID + "'.");
}
else if (action.asString().equalsIgnoreCase("subscribe")) {
Jedis con = connections.get(redisID);
if (con == null) {
Debug.echoError(scriptEntry, "Not connected to redis server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
if (subscriptions.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Already subscribed to a channel on redis server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
JedisPubSub jedisPubSub = new DenizenJedisPubSub(redisID);
subscriptions.put(redisID, jedisPubSub);
String[] channelArr = new String[channels.size()];
for (int i = 0; i < channels.size(); i++) {
channelArr[i] = CoreUtilities.toLowerCase(channels.get(i));
}
runChecked(() -> { con.psubscribe(jedisPubSub, channelArr); scriptEntry.setFinished(true); }, scriptEntry);
}
else if (action.asString().equalsIgnoreCase("unsubscribe")) {
scriptEntry.setFinished(true);
if (!connections.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Not connected to redis server with ID '" + redisID + "'!");
return;
}
if (!subscriptions.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Not subscribed to redis server with ID '" + redisID + "'!");
return;
}
JedisPubSub pubSub = subscriptions.remove(redisID);
try {
pubSub.punsubscribe();
}
catch (Exception e) {
Debug.echoError(e);
}
}
else if (action.asString().equalsIgnoreCase("publish")) {
if (message == null) {
Debug.echoError(scriptEntry, "Must specify a valid message to publish!");
scriptEntry.setFinished(true);
return;
}
final Jedis con = connections.get(redisID);
if (con == null) {
Debug.echoError(scriptEntry, "Not connected to redis server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
if (subscriptions.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Cannot publish messages while subscribed to redis server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
Debug.echoDebug(scriptEntry, "Publishing message '" + message.asString() + "' to channel '" + channel.asString() + "'");
Runnable doQuery = () -> {
try {
ElementTag result = new ElementTag(con.publish(channel.asLowerString(), message.asString()));
scriptEntry.addObject("result", result);
scriptEntry.setFinished(true);
}
catch (final Exception ex) {
DenizenCore.schedule(new OneTimeSchedulable(() -> {
Debug.echoError(scriptEntry, "Redis Exception: " + ex.getMessage());
scriptEntry.setFinished(true);
if (CoreConfiguration.debugVerbose) {
Debug.echoError(scriptEntry, ex);
}
}, 0));
}
};
if (scriptEntry.shouldWaitFor()) {
runChecked(doQuery, scriptEntry);
}
else {
doQuery.run();
}
}
else if (action.asString().equalsIgnoreCase("command")) {
if (command == null) {
Debug.echoError(scriptEntry, "Must specify a valid redis command!");
scriptEntry.setFinished(true);
return;
}
final Jedis con = connections.get(redisID);
if (con == null) {
Debug.echoError(scriptEntry, "Not connected to redis server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
if (subscriptions.containsKey(redisID)) {
Debug.echoError(scriptEntry, "Cannot run commands while subscribed to redis server with ID '" + redisID + "'!");
scriptEntry.setFinished(true);
return;
}
Debug.echoDebug(scriptEntry, "Running command " + command.asString());
Runnable doQuery = () -> {
try {
String redisCommand;
String[] redisArgs;
if (args == null) {
String[] splitCommand = ArgumentHelper.buildArgs(command.asString());
redisCommand = splitCommand[0];
redisArgs = Arrays.copyOfRange(splitCommand, 1, splitCommand.length);
}
else {
redisCommand = command.asString();
redisArgs = args.toArray(new String[0]);
}
ObjectTag result = processResponse(con.sendCommand(() -> SafeEncoder.encode(redisCommand), redisArgs));
scriptEntry.addObject("result", result);
scriptEntry.setFinished(true);
}
catch (final Exception ex) {
DenizenCore.schedule(new OneTimeSchedulable(() -> {
Debug.echoError(scriptEntry, "Redis Exception: " + ex.getMessage());
scriptEntry.setFinished(true);
if (CoreConfiguration.debugVerbose) {
Debug.echoError(scriptEntry, ex);
}
}, 0));
}
};
if (scriptEntry.shouldWaitFor()) {
runChecked(doQuery, scriptEntry);
}
else {
doQuery.run();
}
}
else {
Debug.echoError(scriptEntry, "Unknown action '" + action.asString() + "'");
}
}
catch (Exception ex) {
Debug.echoError(scriptEntry, "Redis Exception: " + ex.getMessage());
if (CoreConfiguration.debugVerbose) {
Debug.echoError(scriptEntry, ex);
}
}
everUsed = true;
RedisHelper.executeCommand(scriptEntry);
}
}

0 comments on commit c7ac457

Please sign in to comment.