fix types in servertagbase and revoke_advancement

DenizenScript · Apr 22, 2021 · 740e9f6 · 740e9f6
1 parent f7edc99
commit 740e9f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/plugin/src/main/java/com/denizenscript/denizen/objects/PlayerTag.java b/plugin/src/main/java/com/denizenscript/denizen/objects/PlayerTag.java
@@ -2551,7 +2551,7 @@ public void adjust(Mechanism mechanism) {
                 return;
             }
             AdvancementProgress prog = getPlayerEntity().getAdvancementProgress(adv);
-            for (String criteria : prog.getRemainingCriteria()) {
+            for (String criteria : prog.getAwardedCriteria()) {
                 prog.revokeCriteria(criteria);
             }
         }

diff --git a/plugin/src/main/java/com/denizenscript/denizen/tags/core/ServerTagBase.java b/plugin/src/main/java/com/denizenscript/denizen/tags/core/ServerTagBase.java
@@ -273,7 +273,7 @@ else if (recipe instanceof CookingRecipe<?>) {
                 return;
             }
             String[] shape = ((ShapedRecipe) recipe).getShape();
-            event.setReplacedObject(new ElementTag(shape[0].length() + "x" + shape.length));
+            event.setReplacedObject(new ElementTag(shape[0].length() + "x" + shape.length).getObjectAttribute(attribute.fulfill(1)));
             return;
         }
 
@@ -290,7 +290,7 @@ else if (recipe instanceof CookingRecipe<?>) {
             if (recipe == null) {
                 return;
             }
-            event.setReplacedObject(new ElementTag(Utilities.getRecipeType(recipe)));
+            event.setReplacedObject(new ElementTag(Utilities.getRecipeType(recipe)).getObjectAttribute(attribute.fulfill(1)));
             return;
         }
 
@@ -306,7 +306,7 @@ else if (recipe instanceof CookingRecipe<?>) {
             if (recipe == null) {
                 return;
             }
-            event.setReplacedObject(new ItemTag(recipe.getResult()));
+            event.setReplacedObject(new ItemTag(recipe.getResult()).getObjectAttribute(attribute.fulfill(1)));
             return;
         }