Skip to content

Commit

Permalink
partially automated cleanups
Browse files Browse the repository at this point in the history
  • Loading branch information
mcmonkey4eva committed Oct 19, 2021
1 parent 24f8ed6 commit 9382274
Show file tree
Hide file tree
Showing 42 changed files with 61 additions and 66 deletions.
5 changes: 2 additions & 3 deletions plugin/src/main/java/com/denizenscript/denizen/Denizen.java
Expand Up @@ -42,7 +42,6 @@
import com.denizenscript.denizencore.DenizenCore;
import com.denizenscript.denizencore.events.OldEventManager;
import com.denizenscript.denizencore.flags.MapTagBasedFlagTracker;
import com.denizenscript.denizencore.flags.SavableMapFlagTracker;
import com.denizenscript.denizencore.objects.ObjectFetcher;
import com.denizenscript.denizencore.objects.core.TimeTag;
import com.denizenscript.denizencore.scripts.ScriptHelper;
Expand Down Expand Up @@ -214,7 +213,7 @@ else if (javaVersion.startsWith("9") || javaVersion.startsWith("1.9") || javaVer
try {
// If Citizens is enabled, Create the NPC Helper
if (Depends.citizens != null) {
npcHelper = new DenizenNPCHelper(this);
npcHelper = new DenizenNPCHelper();
}
// Create our CommandManager to handle '/denizen' commands
commandManager = new CommandManager();
Expand Down Expand Up @@ -386,7 +385,7 @@ else if (javaVersion.startsWith("9") || javaVersion.startsWith("1.9") || javaVer
Depends.setupCitizens();
if (Depends.citizens != null) {
getLogger().warning("Citizens was activated late - this means a plugin load order error occurred. You may have plugins with invalid 'plugin.yml' files (eg that use the 'loadbefore' directive, or that have circular dependencies).");
npcHelper = new DenizenNPCHelper(this);
npcHelper = new DenizenNPCHelper();
Depends.citizens.registerCommandClass(NPCCommandHandler.class);
TraitRegistry.registerMainTraits();
triggerRegistry.registerCoreMembers();
Expand Down
Expand Up @@ -5,7 +5,6 @@
import com.denizenscript.denizen.nms.util.jnbt.IntArrayTag;
import com.denizenscript.denizen.nms.util.jnbt.Tag;
import com.denizenscript.denizen.objects.ItemTag;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.NamespacedKey;
import org.bukkit.inventory.Inventory;
Expand Down
Expand Up @@ -27,16 +27,14 @@

public class DenizenNPCHelper implements Listener {

private Denizen plugin;
private ActionHandler actionHandler;

public DenizenNPCHelper(Denizen denizen) {
plugin = denizen;
public DenizenNPCHelper() {
if (Depends.citizens != null) {
plugin.getServer().getPluginManager().registerEvents(this, plugin);
Bukkit.getPluginManager().registerEvents(this, Denizen.getInstance());
INVENTORY_TRAIT_VIEW = ReflectionHelper.getFields(net.citizensnpcs.api.trait.trait.Inventory.class).get("view");
}
actionHandler = new ActionHandler(plugin);
actionHandler = new ActionHandler();
}

/**
Expand Down
Expand Up @@ -5,7 +5,6 @@
import com.denizenscript.denizen.scripts.containers.core.AssignmentScriptContainer;
import com.denizenscript.denizen.utilities.debugging.Debug;
import com.denizenscript.denizen.utilities.implementation.BukkitScriptEntryData;
import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizencore.objects.core.ElementTag;
import com.denizenscript.denizencore.objects.ArgumentHelper;
import com.denizenscript.denizencore.objects.ObjectTag;
Expand All @@ -21,10 +20,7 @@

public class ActionHandler {

final Denizen denizen;

public ActionHandler(Denizen denizen) {
this.denizen = denizen;
public ActionHandler() {
}

public String doAction(String actionName, NPCTag npc, PlayerTag player, AssignmentScriptContainer assignment, Map<String, ObjectTag> context) {
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.npc.traits;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.nms.abstracts.ProfileEditor;
import com.denizenscript.denizen.utilities.packets.NetworkInterceptHelper;
Expand Down
Expand Up @@ -2,7 +2,6 @@

import com.denizenscript.denizen.events.BukkitScriptEvent;
import com.denizenscript.denizen.nms.NMSHandler;
import com.denizenscript.denizen.utilities.debugging.Debug;
import com.denizenscript.denizen.utilities.depends.Depends;
import com.denizenscript.denizen.utilities.flags.LocationFlagSearchHelper;
import com.denizenscript.denizencore.objects.ObjectTag;
Expand Down Expand Up @@ -74,7 +73,7 @@ default ListTag getBlocksFlagged(String flagName, Attribute attribute) {
return blocks;
}

public static void registerTags(ObjectTagProcessor<? extends AreaContainmentObject> processor) {
static void registerTags(ObjectTagProcessor<? extends AreaContainmentObject> processor) {

// <--[tag]
// @attribute <AreaObject.bounding_box>
Expand Down
Expand Up @@ -521,8 +521,7 @@ public static void registerTags() {
// Returns an item of the material.
// -->
registerTag("item", (attribute, object) -> {
ItemTag item = new ItemTag(object, 1);
return item;
return new ItemTag(object, 1);
});

// <--[tag]
Expand Down
Expand Up @@ -11,7 +11,6 @@
import com.denizenscript.denizencore.utilities.CoreUtilities;
import org.bukkit.Material;
import org.bukkit.inventory.meta.MapMeta;
import org.bukkit.map.MapView;

import java.util.List;

Expand Down
Expand Up @@ -53,14 +53,12 @@ private ItemPotion(ItemTag item) {
ItemTag item;

public static String stringifyEffect(PotionEffect effect) {
StringBuilder sb = new StringBuilder();
sb.append(effect.getType().getName()).append(",")
.append(effect.getAmplifier()).append(",")
.append(effect.getDuration()).append(",")
.append(effect.isAmbient()).append(",")
.append(effect.hasParticles()).append(",")
.append(effect.hasIcon());
return sb.toString();
return effect.getType().getName() + "," +
effect.getAmplifier() + "," +
effect.getDuration() + "," +
effect.isAmbient() + "," +
effect.hasParticles() + "," +
effect.hasIcon();
}

public static PotionEffect parseEffect(String str, TagContext context) {
Expand Down
@@ -1,6 +1,5 @@
package com.denizenscript.denizen.scripts.commands.core;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.scripts.containers.core.InteractScriptContainer;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.entity;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.entity;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.nms.interfaces.EntityHelper;
import com.denizenscript.denizen.utilities.Utilities;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.entity;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.npc;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.npc;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.player;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.debugging.Debug;
import com.denizenscript.denizen.nms.NMSHandler;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.player;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.player;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.server;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.command.scripted.DenizenCommandSender;
import com.denizenscript.denizen.utilities.Utilities;
Expand Down
Expand Up @@ -2,7 +2,6 @@

import com.denizenscript.denizen.objects.EntityTag;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.entity.FakeOfflinePlayer;
import com.denizenscript.denizen.utilities.ScoreboardHelper;
import com.denizenscript.denizen.utilities.debugging.Debug;
import com.denizenscript.denizen.objects.PlayerTag;
Expand All @@ -15,8 +14,6 @@
import com.denizenscript.denizencore.scripts.ScriptEntry;
import com.denizenscript.denizencore.scripts.commands.AbstractCommand;
import com.denizenscript.denizencore.utilities.CoreUtilities;
import org.bukkit.Bukkit;
import org.bukkit.OfflinePlayer;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.DisplaySlot;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.world;

import com.denizenscript.denizen.utilities.blocks.ChunkCoordinate;
import com.denizenscript.denizen.utilities.debugging.Debug;
import com.denizenscript.denizen.utilities.depends.Depends;
Expand Down Expand Up @@ -28,10 +29,9 @@ public ChunkLoadCommand() {
setName("chunkload");
setSyntax("chunkload ({add}/remove/removeall) [<chunk>|...] (duration:<value>)");
setRequiredArguments(1, 3);
Denizen denizen = Denizen.getInstance();
denizen.getServer().getPluginManager().registerEvents(this, denizen);
Bukkit.getPluginManager().registerEvents(this, Denizen.getInstance());
if (Depends.citizens != null) {
denizen.getServer().getPluginManager().registerEvents(new ChunkLoadCommandNPCEvents(), denizen);
Bukkit.getPluginManager().registerEvents(new ChunkLoadCommandNPCEvents(), Denizen.getInstance());
}
isProcedural = false;
}
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.world;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Settings;
import com.denizenscript.denizen.utilities.Utilities;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.world;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.world;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.commands.world;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.Utilities;
import com.denizenscript.denizen.utilities.debugging.Debug;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.containers.core;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.command.scripted.DenizenAliasHelpTopic;
import com.denizenscript.denizen.utilities.command.scripted.DenizenCommand;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.containers.core;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.implementation.BukkitScriptEntryData;
import com.denizenscript.denizen.objects.PlayerTag;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.scripts.containers.core;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.utilities.debugging.Debug;
import com.denizenscript.denizen.utilities.implementation.BukkitScriptEntryData;
Expand Down
Expand Up @@ -6,7 +6,6 @@
import com.denizenscript.denizencore.utilities.CoreUtilities;
import com.google.common.base.Splitter;
import com.denizenscript.denizen.objects.PlayerTag;
import com.denizenscript.denizen.scripts.commands.server.ScoreboardCommand;
import org.bukkit.Bukkit;
import org.bukkit.OfflinePlayer;
import org.bukkit.configuration.ConfigurationSection;
Expand Down
Expand Up @@ -116,8 +116,7 @@ public static CuboidBlockSet fromSpongeStream(InputStream is) {
int cbsIndex = z + y * cbs.z_height + x * cbs.z_height * cbs.y_length;
BlockVector pt = new BlockVector(x, y, z);
if (tileEntitiesMap.containsKey(pt)) {
CompoundTag otag = NMSHandler.getInstance().createCompoundTag(tileEntitiesMap.get(pt));
block.tileEntityData = otag;
block.tileEntityData = NMSHandler.getInstance().createCompoundTag(tileEntitiesMap.get(pt));
}
cbs.blocks[cbsIndex] = block;
index++;
Expand Down
Expand Up @@ -21,10 +21,7 @@

public class DenizenCommandHandler {

private final Denizen denizen;

public DenizenCommandHandler(Denizen denizen) {
this.denizen = denizen;
public DenizenCommandHandler() {
}

// <--[language]
Expand Down Expand Up @@ -275,10 +272,10 @@ public void save(CommandContext args, CommandSender sender) throws CommandExcept
min = 1, max = 3, permission = "denizen.basic", flags = "a")
public void reload(CommandContext args, CommandSender sender) throws CommandException {
if (args.hasFlag('a')) {
denizen.reloadConfig();
Denizen.getInstance().reloadConfig();
DenizenCore.reloadScripts();
NoteManager.reload();
denizen.reloadSaves();
Denizen.getInstance().reloadSaves();
Messaging.send(sender, "Denizen save data, config, and scripts reloaded from disk to memory.");
if (ScriptHelper.hadError()) {
Messaging.sendError(sender, "There was an error loading your scripts, check the console for details!");
Expand All @@ -287,7 +284,7 @@ public void reload(CommandContext args, CommandSender sender) throws CommandExce
}
if (args.length() > 2) {
if (args.getString(1).equalsIgnoreCase("saves")) {
denizen.reloadSaves();
Denizen.getInstance().reloadSaves();
Messaging.send(sender, "Denizen save data reloaded from disk to memory.");
return;
}
Expand All @@ -297,7 +294,7 @@ else if (args.getString(1).equalsIgnoreCase("notes")) {
return;
}
else if (args.getString(1).equalsIgnoreCase("config")) {
denizen.reloadConfig();
Denizen.getInstance().reloadConfig();
Messaging.send(sender, "Denizen config file reloaded from disk to memory.");
return;
}
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.utilities.debugging;

import com.denizenscript.denizen.Denizen;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.utilities.depends;

import com.denizenscript.denizen.Denizen;
import com.google.common.io.ByteArrayDataOutput;
import com.google.common.io.ByteStreams;
Expand Down
@@ -1,4 +1,5 @@
package com.denizenscript.denizen.utilities.entity;

import com.denizenscript.denizen.Denizen;
import com.denizenscript.denizen.objects.EntityTag;
import com.denizenscript.denizen.utilities.packets.NetworkInterceptHelper;
Expand Down
Expand Up @@ -13,7 +13,6 @@
import com.denizenscript.denizen.nms.NMSHandler;
import com.denizenscript.denizen.utilities.maps.DenizenMapManager;
import com.denizenscript.denizencore.DenizenImplementation;
import com.denizenscript.denizencore.flags.AbstractFlagTracker;
import com.denizenscript.denizencore.flags.FlaggableObject;
import com.denizenscript.denizencore.objects.Argument;
import com.denizenscript.denizencore.objects.ObjectFetcher;
Expand Down
Expand Up @@ -3,7 +3,6 @@
import com.denizenscript.denizen.objects.ColorTag;
import com.denizenscript.denizen.objects.PlayerTag;
import com.denizenscript.denizen.utilities.debugging.Debug;
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.map.MapCanvas;
import org.bukkit.map.MapPalette;
Expand Down
Expand Up @@ -13,7 +13,6 @@
import com.denizenscript.denizencore.utilities.CoreUtilities;
import net.minecraft.server.v1_14_R1.*;
import org.bukkit.Bukkit;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.NamespacedKey;
import org.bukkit.craftbukkit.libs.it.unimi.dsi.fastutil.objects.Object2ObjectLinkedOpenHashMap;
Expand Down
Expand Up @@ -13,7 +13,6 @@
import com.denizenscript.denizencore.utilities.CoreUtilities;
import net.minecraft.server.v1_15_R1.*;
import org.bukkit.Bukkit;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.NamespacedKey;
import org.bukkit.craftbukkit.libs.it.unimi.dsi.fastutil.objects.Object2ObjectLinkedOpenHashMap;
Expand Down
Expand Up @@ -18,7 +18,6 @@
import net.md_5.bungee.chat.ComponentSerializer;
import net.minecraft.server.v1_16_R3.*;
import org.bukkit.Bukkit;
import org.bukkit.Color;
import org.bukkit.Material;
import org.bukkit.NamespacedKey;
import org.bukkit.craftbukkit.libs.it.unimi.dsi.fastutil.objects.Object2ObjectLinkedOpenHashMap;
Expand Down

0 comments on commit 9382274

Please sign in to comment.