change an unused config option

DenizenScript · Feb 25, 2019 · 93bb3a3 · 93bb3a3
1 parent c4d5901
commit 93bb3a3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/plugin/src/main/java/net/aufdemrand/denizen/Settings.java b/plugin/src/main/java/net/aufdemrand/denizen/Settings.java
@@ -228,23 +228,30 @@ public static boolean allowStupids() {
     }
 
     public static boolean allowStupid1() {
+        // Unrestricted file access can cause a lot of problems in itself, and encourage a style of script
+        // writing that is extremely poor and can be done in much more effective and clean ways.
+        // If you believe you need to make use of this config option... strongly consider any possible alternatives.
+        //
+        // Generally, be aware that if you are not completely clear on exactly how these settings work internally in Java,
+        // and what changing them can do, ... you just should not use them.
+        // This is for very highly experienced users only.
         return DenizenAPI.getCurrentInstance().getConfig()
-                .getBoolean("Commands.General.Allow stupid file abuse you moron dont enable this", false);
+                .getBoolean("Commands.General.Allow unrestricted file access", false);
     }
 
     public static boolean allowStupid2() {
         return DenizenAPI.getCurrentInstance().getConfig()
-                .getBoolean("Commands.General.are you sure", false);
+                .getBoolean("Commands.General.Confirm allowing unrestricted file access", false);
     }
 
     public static boolean allowStupid3() {
         return DenizenAPI.getCurrentInstance().getConfig()
-                .getBoolean("Commands.General.are you absolutely seriously sure dont enable this", false);
+                .getBoolean("Commands.General.Unrestricted file access is very bad and dangerous are you sure you want that", false);
     }
 
     public static boolean allowStupidx() {
         return DenizenAPI.getCurrentInstance().getConfig()
-                .getBoolean("Commands.General.This one dont touch", false);
+                .getBoolean("Commands.General.Don't change this unrestricted file access option though", false);
     }
 
     public static boolean allowFilecopy() {

diff --git a/plugin/src/main/resources/config.yml b/plugin/src/main/resources/config.yml
@@ -129,16 +129,8 @@ Commands:
         # Whether to allow scripts to read arbitrary data from the web, which can also potentially enable tracking of your private server data.
         # Generally this is safe, but set to 'false' if you want very strict security.
         Allow: true
-  General:
-        # NEVER EVER ENABLE ANY OF THESE.
-        # THEY WILL BORK YOUR SERVER.
-        # ESPECIALLY NOT IF YOU'RE NOT A JAVA DEVELOPER!!!
-        Allow stupid file abuse you moron dont enable this: false
-        are you sure: false
-        are you absolutely seriously sure dont enable this: false
-        This one dont touch: false
     # GENERAL SECURITY NOTE: Always run your server on a user with access to nothing but the minecraft folder
-    # Otherwise, a bad script or plugin could potentially damage things
+    # Otherwise, a bad script or plugin could potentially damage things (though being careful with these settings should reduce the risk of a script doing so)
     # ALSO: Always read scripts you download for anything suspicious looking, EG the log command, the file_delete mechanism, ...
 
 Tags: