strip the display tag from items when setting lore to empty

DenizenScript · Aug 6, 2023 · b62926e · b62926e
1 parent 2ba64c9
commit b62926e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/v1_19/src/main/java/com/denizenscript/denizen/nms/v1_19/helpers/ItemHelperImpl.java b/v1_19/src/main/java/com/denizenscript/denizen/nms/v1_19/helpers/ItemHelperImpl.java
@@ -338,7 +338,10 @@ public void setLore(ItemTag item, List<String> lore) {
             tag.put("display", display);
         }
         if (lore == null || lore.isEmpty()) {
-            display.put("Lore", null);
+            display.remove("Lore");
+            if (display.isEmpty()) {
+                tag.remove("display");
+            }
         }
         else {
             ListTag tagList = new ListTag();

diff --git a/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/ItemHelperImpl.java b/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/ItemHelperImpl.java
@@ -353,7 +353,10 @@ public void setLore(ItemTag item, List<String> lore) {
             tag.put("display", display);
         }
         if (lore == null || lore.isEmpty()) {
-            display.put("Lore", null);
+            display.remove("Lore");
+            if (display.isEmpty()) {
+                tag.remove("display");
+            }
         }
         else {
             ListTag tagList = new ListTag();