additional little improvements (remove some legacy code)

plugin/src/main/java/com/denizenscript/denizen/nms/interfaces/PacketHelper.java

@@ -34,7 +34,9 @@ public interface PacketHelper {
 
     void setVision(Player player, EntityType entityType);
 
-    void showDemoScreen(Player player);
+    default void showDemoScreen(Player player) {
+        throw new UnsupportedOperationException();
+    }
 
     void showBlockAction(Player player, Location location, int action, int state);
 

plugin/src/main/java/com/denizenscript/denizen/nms/interfaces/Particle.java

@@ -12,10 +12,6 @@ public Particle(org.bukkit.Particle particle) {
         this.particle = particle;
     }
 
-    public void playFor(Player player, Location location, int count, Vector offset, double extra) {
-        player.spawnParticle(particle, location, count, offset.getX(), offset.getY(), offset.getZ(), extra);
-    }
-
     public <T> void playFor(Player player, Location location, int count, Vector offset, double extra, T data) {
         player.spawnParticle(particle, location, count, offset.getX(), offset.getY(), offset.getZ(), extra, data);
     }

plugin/src/main/java/com/denizenscript/denizen/objects/PlayerTag.java

@@ -1,6 +1,7 @@
 package com.denizenscript.denizen.objects;
 
 import com.denizenscript.denizen.events.BukkitScriptEvent;
+import com.denizenscript.denizen.nms.NMSVersion;
 import com.denizenscript.denizen.nms.interfaces.AdvancementHelper;
 import com.denizenscript.denizen.objects.properties.entity.EntityHealth;
 import com.denizenscript.denizen.scripts.commands.player.DisguiseCommand;
@@ -3228,7 +3229,12 @@ else if (split.length > 1) {
         // Shows the player the demo screen.
         // -->
         if (mechanism.matches("show_demo")) {
-            NMSHandler.getPacketHelper().showDemoScreen(getPlayerEntity());
+            if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_18)) {
+                getPlayerEntity().showDemoScreen();
+            }
+            else {
+                NMSHandler.getPacketHelper().showDemoScreen(getPlayerEntity());
+            }
         }
 
         // <--[mechanism]

v1_18/src/main/java/com/denizenscript/denizen/nms/v1_18/Handler.java

@@ -76,7 +76,7 @@ public Handler() {
         itemHelper = new ItemHelperImpl();
         soundHelper = new SoundHelperImpl();
         packetHelper = new PacketHelperImpl();
-        particleHelper = new ParticleHelperImpl();
+        particleHelper = new ParticleHelper();
         playerHelper = new PlayerHelperImpl();
         worldHelper = new WorldHelperImpl();
         enchantmentHelper = new EnchantmentHelperImpl();

v1_18/src/main/java/com/denizenscript/denizen/nms/v1_18/helpers/PacketHelperImpl.java

@@ -187,11 +187,6 @@ else if (entityType == EntityType.ENDERMAN) {
                 ((CraftWorld) player.getWorld()).getHandle(), true, player.getLocation(), false);
     }
 
-    @Override
-    public void showDemoScreen(Player player) {
-        send(player, new ClientboundGameEventPacket(ClientboundGameEventPacket.DEMO_EVENT, 0f));
-    }
-
     @Override
     public void showBlockAction(Player player, Location location, int action, int state) {
         BlockPos position = new BlockPos(location.getX(), location.getY(), location.getZ());