fix NPE in advancement code in 1.20.2

DenizenScript · Oct 17, 2023 · e347bd9 · e347bd9
1 parent af1bbc6
commit e347bd9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/AdvancementHelperImpl.java b/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/AdvancementHelperImpl.java
@@ -192,7 +192,7 @@ private static AdvancementHolder asNMSCopy(com.denizenscript.denizen.nms.util.Ad
             }
         }
         AdvancementRequirements reqs = new AdvancementRequirements(requirements);
-        Advancement adv = new Advancement(Optional.of(parent.id()), Optional.of(display), AdvancementRewards.EMPTY, criteria, reqs, false); // TODO: 1.20: do we want to ever enable telemetry?
+        Advancement adv = new Advancement(parent == null ? Optional.empty() : Optional.of(parent.id()), Optional.of(display), AdvancementRewards.EMPTY, criteria, reqs, false); // TODO: 1.20: do we want to ever enable telemetry?
         return new AdvancementHolder(key, adv);
     }