Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaterialTag.has_eye property #2291

Merged
merged 4 commits into from Jan 17, 2022
Merged

Add MaterialTag.has_eye property #2291

merged 4 commits into from Jan 17, 2022

Conversation

tal5
Copy link
Member

@tal5 tal5 commented Jan 15, 2022

Adds a MaterialTag property that controls whether end portal frames have an ender eye.

@@ -220,6 +220,7 @@ public static void registerMainProperties() {
PropertyParser.registerProperty(MaterialSwitchFace.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialUnstable.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialWaterlogged.class, MaterialTag.class);
PropertyParser.registerProperty(MaterialHasEye.class, MaterialTag.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of alphabetical order

@mcmonkey4eva
Copy link
Member

Is there any reason this is its own property and not just bulked into switched?

@tal5
Copy link
Member Author

tal5 commented Jan 16, 2022

Is there any reason this is its own property and not just bulked into switched?

Added into MaterialTag.switched

return getPiston().isExtended();
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic java formatting is wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that, my bad

@mcmonkey4eva mcmonkey4eva merged commit cbcf3bf into DenizenScript:dev Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants