Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cause matching in EntityDamaged/KilledScriptEvent #2392

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Fix cause matching in EntityDamaged/KilledScriptEvent #2392

merged 2 commits into from
Oct 22, 2022

Conversation

tal5
Copy link
Member

@tal5 tal5 commented Oct 20, 2022 •
edited

Changes

  • Changed the damage cause matching to runGenericCheck instead of an equals check
  • Removed the now redundant cause field in favor of getting it from the event
  • Updated EntityKilledScriptEvent to modern getContext handling (switch/case)

Notes

@mcmonkey4eva mcmonkey4eva merged commit ba8762c into DenizenScript:dev Oct 22, 2022
@tal5 tal5 deleted the Fix_EntityDamagedScriptEvent_Cause branch November 8, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tal5 @mcmonkey4eva