Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
resetWorldBorder
now usesPlayer#setWorldBorder(null)
on 1.18+.setWorldBorder
now usesPlayer#setWorldBorder
on 1.18+.showDemoScreen
now has the API implementation as the default inPacketHelper
as opposed to a version check in the mechanism code.resetTabListHeaderFooter
was removed in favor ofPlayer#setPlayerListHeaderFooter(null, null)
, this API can't be used to set actual text as it doesn't support advanced text formatting.showEquipment
now usesPlayer#sendEquipmentChange
on 1.18+.openBook
was removed in favor ofPlayer#openBook
.showExperience
andresetExperience
were removed in favor ofPlayer#sendExperienceChange
.showSignEditor
's opening an actual sign functionality was replaced byPlayer#openSign
on 1.18+, and it was changed tovoid
as it's return value is now unused.Notes
resetEquipment
was not replaced asPlayer#sendEquipmentChange
only takes oneslot -> item
pair at a time but the packet allows several, which means switching to Spigot's method would be 6x more packets, let me know if it should still be replaced.respawn
was not replaced byPlayer.Spigot#respawn
as the NMS method currently used has a few more features (e.g. handles the world being hardcore and respawns the player in spectator mode if so) which the Spigot method does not, let me know if it should still be replaced / replaced and have the extra functionality replicated with API.PlayerTag.edit_sign
's error handling is slightly different, it will now error if an input is given but it isn't a valid LocationTag, but still default to opening a fake editor for back-support, let me know if that should be reverted.Paper
andSpigot
,1.19.2
and1.16.5
.