Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
BrewingRecipe
class - a temporary class to hold an input, ingredient, and result of a brewing recipe. Can be replaced by Paper's one once Spigot support is dropped.ItemHelper#getCustomBrewingRecipes
- returns a Map of keys to brewing recipes.ItemHelper#getCustomBrewingRecipeIDs
- returns a Set of all brewing recipe keys.ItemHelper#getCustomBrewingRecipe
- returns a brewing recipe by ID.ItemHelperImpl#getNMSCustomBrewingRecipes
- returns the internal custom brewing recipe mapItemHelperImpl#paperMixToRecipe
- converts paper'sPaperPotionMix
into aBrewingRecipe
.Changes
ItemTag.recipe_ids
,server.recipe_ids
,server.recipe_items
,server.recipe_type
, andserver.recipe_result
now support custom brewing recipes on Paper servers.Notes
BrewingRecipe
's with reflection for simple things such as getting the IDs. We could maybe remove them once we go Paper-only and that code is cleaned up - Let me know if these methods should be merged already.