Add mount_to arg to fakespawn command #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
reviewed
Aug 4, 2023
| Debug.echoError(e); | ||
| } | ||
| for (PlayerTag player : players) { | ||
| ((CraftPlayer) player.getPlayerEntity()).getHandle().connection.send(packet); |
tal5
reviewed
Aug 4, 2023
| @@ -101,6 +103,22 @@ public void deTrackEntity(Player player, Entity entity) { | |||
|
|
|||
| public record TrackerData(PlayerTag player, ServerEntity tracker) {} | |||
|
|
|||
| @Override | |||
| public void addFakePassenger(List<PlayerTag> players, Entity vehicle, FakeEntity fakeEntity) { | |||
There was a problem hiding this comment.
fakeEntity -> fakePassenger or something like that
tal5
reviewed
Aug 4, 2023
| } | ||
| players = Collections.singletonList(Utilities.getEntryPlayer(scriptEntry)); |
tal5
reviewed
Aug 4, 2023
plugin/src/main/java/com/denizenscript/denizen/scripts/commands/player/FakeSpawnCommand.java
Show resolved
Hide resolved
tal5
reviewed
Aug 4, 2023
Comment on lines
71
to
72
| @ArgName("entity") @ArgLinear EntityTag entity, | ||
| @ArgName("location") @ArgLinear @ArgDefaultNull LocationTag location, |
There was a problem hiding this comment.
I believe these two would need legacy out-of-order args handling? (note that cancel shouldn't need that as it's a boolean arg).
tal5
reviewed
Aug 4, 2023
| @@ -76,6 +77,7 @@ public class PlayerHelperImpl extends PlayerHelper { | |||
|
|
|||
| public static final Field FLY_TICKS = ReflectionHelper.getFields(ServerGamePacketListenerImpl.class).get(ReflectionMappingsInfo.ServerGamePacketListenerImpl_aboveGroundTickCount, int.class); | |||
| public static final Field VEHICLE_FLY_TICKS = ReflectionHelper.getFields(ServerGamePacketListenerImpl.class).get(ReflectionMappingsInfo.ServerGamePacketListenerImpl_aboveGroundVehicleTickCount, int.class); | |||
| public static final Field ENTITY_PASSENGERS = ReflectionHelper.getFields(ClientboundSetPassengersPacket.class).get(ReflectionMappingsInfo.ClientboundSetPassengersPacket_passengers, int[].class); | |||
There was a problem hiding this comment.
Would probably name this PASSENGERS_PACKET_PASSENGERS or something, ENTITY_PASSENGERS isn't really clear
|
Pushed up all the above requested changes |
mcmonkey4eva
reviewed
Sep 2, 2023
| } | ||
|
|
||
| // <--[command] | ||
| // @Name FakeSpawn | ||
| // @Syntax fakespawn [<entity>] [<location>/cancel] (players:<player>|...) (d:<duration>{10s}) | ||
| // @Syntax fakespawn [<entity>] [<location>/cancel] (players:<player>|...) (duration:<duration>{10s}) (mount_to:<entity>) | ||
| // @Required 2 | ||
| // @Maximum 4 |
There was a problem hiding this comment.
This value needs to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested on 1.20.1