NPC matcher-switch #2544
Merged
NPC matcher-switch #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be ready for review now 👍. All the other NPC events have had the switch added. I also tested them all on 1.20.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
npc:entity matcher switches to NPC related eventsnpc spawnsAdds the
npc:switch to allow the use of a matcher such asnpc_flagged. Also adds thecause:switch to match for the cause for convenience.Note
This is currently a draft PR because I think it will be nice to add consistency between the NPC events so they all can have the
npc:matcher switch. I want to make sure did this right before I add support for the other events. If this PR should just be for this event only then let me know and I'll turn it into a normal PR.