Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WardenChangesAngerLevelScriptEvent
's determination registration properly useregisterOptionalDetermination
to returnfalse
for invalid input.BlockHelper#getMapColor
using Spigot's newBlockData#getMapColor
.EntityHelper#getEntity(World, UUID)
in favor of Spigot'sBukkit#getEntity(UUID)
.EntityHelper#getPlayersThatSee
using Spigot's newEntity#getTrackedBy
.EntityTag#getEntityForID
now usesBukkit#getEntity
.EntityBoatType#setPropertyValue
.attacker.getEquipment().getItemInMainHand() != null
fromEntityHelperImpl(1.20)#getDamageTo
, asgetItemInMainHand
isn't nullable.PlayerHelperImpl(1.20)#refreshPlayer
now usesServerPlayer#createCommonSpawnInfo
instead of manually creating the spawn info.BiomeNMSImpl(1.20)#getSpawnableEntities
now uses the newCraftEntityType#minecraftToBukkit
instead of the existing hacky conversion.DisguisePacketHandlers
to after theEntityMetadataPacketHandlers
, to avoid stuff like theinvisible
command overriding disguised entity's visibility.DisguisePacketHandlers#processTeleportPacket
now usesDenizenNetworkManagerImpl#copyPacket
instead of manually creating a new packet and copying values over (which also means relevant reflection constants were removed).ClientboundAddPlayerPacket
handling code.PlayerTag.skin_model
breaking on 1.17 because Spigot's player profile API didn't exist back then, and uses aMultiVersionHelper
because Java doesn't like it when enums that don't exist are referenced.Additions
MultiVersionHelper1_18
- used byPlayerTag.skin_model
, because that API didn't exist before 1.18 and it has an enum.