Modernize server list ping event determinations
#2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I must have accidentally pressed enter
mcmonkey4eva
reviewed
Jan 3, 2024
| } | ||
| return true; | ||
| } | ||
| if (determination.length() > 0 && !determineLow.equalsIgnoreCase("none")) { |
There was a problem hiding this comment.
I was going to ask where this none handling went, but on closer inspection... what is this / why was it ever here? 0.o it doesn't seem to do anything in the old code.
mcmonkey4eva
reviewed
Jan 3, 2024
plugin/src/main/java/com/denizenscript/denizen/events/server/ListPingScriptEvent.java
Show resolved
Hide resolved
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize
server list pingevent determinationsSorry for misunderstanding the previous feature request haha.
This PR is just a duplicate of my previous one (#2584) but without the
NUM_PLAYERSdetermination.馃槄