Lectern page tag/mech fix #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -320,6 +320,12 @@ public class BukkitImplDeprecations { | |||
| // Added 2023/11/16, deprecate officially by 2027 | |||
| public static Warning takeExperience = new FutureWarning("takeExperience", "Using the 'take' command to take experience is deprecated in favor of the 'experience' command."); | |||
|
|
|||
| // Added 2024/02/19, deprecate officially by 2027. | |||
| public static Warning lecternPageMech = new FutureWarning("lecternPageMech", "The mechanism 'LocationTag.lectern_page' is deprecated in favor of 'LocationTag.page'."); | |||
There was a problem hiding this comment.
should just have one dep for both instead of separate
tal5
reviewed
Feb 26, 2024
Comment on lines
3704
to
3705
| BlockState state = object.getBlockStateForTag(attribute); | ||
| if (state instanceof Lectern lectern) { |
There was a problem hiding this comment.
state variables are a bit redundant here (and in the mech), as they're only ever needed in the instanceof check which creates the variable that's actually used - can just in-line them like most newer tags/mechs do.
mcmonkey4eva
approved these changes
Feb 28, 2024
tal5
reviewed
Mar 4, 2024
| tagProcessor.registerMechanism("page", false, ElementTag.class, (object, mechanism, input) -> { | ||
| if (object.getBlockState() instanceof Lectern lectern) { | ||
| lectern.setPage(input.asInt() - 1); | ||
| object.getBlockState().update(); |
There was a problem hiding this comment.
Need to Mechanism#requireInteger in here, probably as an early return before the state checks
tal5
reviewed
Mar 4, 2024
| object.getBlockState().update(); | ||
| } | ||
| else { | ||
| Debug.echoError("The 'LocationTag.page' mechanism can only be called on a lectern block."); |
tal5
reviewed
Mar 8, 2024
| // @name page | ||
| // @input ElementTag(Number) | ||
| // @description | ||
| // Changes the page currently displayed on the book in a lectern block. |
tal5
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming back to an old PR of mine that I closed because I was too dumb at the time lol: Fixes the Lectern page mech and tag. #2484
Deprecates the
lectern_pagetag & mech as they are one number off, ie If a book on a lectern is on page 14, the tag will return 13. & if you want to change the page on the lectern, you have to set the number to be one number higher than the preferred page.