Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Warning
s toJobsBridge
, just to have them all in once place for easier bumping in the future.Warning
's field names to match their IDs, just a standard used in core/Denizen.jobs
(tag base) to theListTag
convertor constructor.jobs_job
constructor tag's handling to useJobsJobTag
as the param type instead of handling it manually.JobsCommand
registration to be with the rest of the registrations instead of at the bottom.JobsCommand
to modern command handling (with legacy handling for out-of-order args).JobsCommand
, new line after dot.JobsCommand
.JobsCommand
now uses the methods onPlayerManager
instead of the ones onJobsPlayer
, as these are the ones that handle saving the changes and all (reported on Discord).JobsCommand
to the modern switch syntax.tryArgObject
forJobsJobTag
matching).JobsJobTag
's meta example (it was meant to bemcmonkey
's UUID, but the wrongmcmonkey
was used. This is a very big problem).advancedMatches
and addedMatchable
meta toJobsJobTag
.JobsJobTag#valueOf
's handling of the player UUID input - It now parses it as just a UUID instead of aPlayerTag
, mainly as stuff likePlayerName,job
shouldn't be allowed.Also changed the checking of whether the player is valid to trying to get it from jobs + a null check, instead of
PlayerTag#isValid
.starts with prefix -> true
intoJobsJobTag#matches
, before doing avalueOf != null
.JobsJobTag#get/setOwner
to use aUUID
instead of aPlayerTag
.JobsJobTag
, to have less relevant methods such asget/setPrefix
at the bottom and stuff likeregister
higher up.ElementTag
s as plain-text where relevant.JobsJobTag.xp/max_xp (tag)
to use early return.JobsJobTag.level
to use a ternary operator.JobsJobTag.xp (mechanism)
to modern mech registration.JobsJobTag.tagProcessor
asfinal
.JobsJobTag#debuggable
.JobsPlayerProperties
to a modernJobsPlayerExtensions
extension class.registerPropertyTagHandlers
call inJobsJobTag#register
, as it doesn't look like it has any properties?contains("@") -> null
check inJobsJobTag#valueOf
, which seems like it was a mistake or something? don't see a reason to have that, but correct me if I'm wrong.JobsJobTag#identify
to use the newJobsJobTag#identify(prefix, separator)
method.Additions
jobsSingleLineDescription
deprecation warning forJobsJobTag.description
, as it was deprecated but didn't have a proper warning.JobsJobTag#identify(String prefix, String separator)
- used byidentify
anddebuggable
to avoid duplicate logic.