Add support for NoteblockAPI's PositionSongPlayer
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pom.xml
Outdated
| @@ -236,7 +236,7 @@ | |||
| <dependency> | |||
| <groupId>com.github.koca2000</groupId> | |||
| <artifactId>NoteBlockAPI</artifactId> | |||
| <version>1.2.2.1</version> | |||
| <version>1.6.2</version> | |||
There was a problem hiding this comment.
please remove this change from the PR so it can be applied separately
| return; | ||
| } | ||
| String directory = URLDecoder.decode(System.getProperty("user.dir")); | ||
| Song s = NBSDecoder.parse(new File(directory + "/plugins/Denizen/" + file + ".nbs")); |
There was a problem hiding this comment.
This is an issue with the original code not this PR, but this file handling is wrong - it should look more like
File file = new File(Denizen.getInstance().getDataFolder(), fName + ".nbs");
if (!Utilities.canReadFile(file)) {
Debug.echoError("Cannot read from that file path due to security settings in Denizen/config.yml.");
return;
}
|
Done |
mcmonkey4eva
approved these changes
Feb 28, 2024
|
Removed |
tal5
reviewed
Mar 4, 2024
| } | ||
| else { | ||
| throw new InvalidArgumentsException("Must specify players to add, remove or spectate!"); | ||
| throw new InvalidArgumentsRuntimeException("Must specify players to add or remove!"); |
There was a problem hiding this comment.
This message still isn't really clear, probably players to play/stop a song for or something?
|
Done 👍 |
mcmonkey4eva
reviewed
Mar 6, 2024
| } | ||
|
|
||
| // <--[command] | ||
| // @Name nbs | ||
| // @Syntax nbs [play/stop] (file:<file path>) (targets:<entity>|...) | ||
| // @Syntax nbs [play/stop] (file:<file_path>) (targets:<entity>|...) (at:<location>) (distance:<#>{16}) |
|
Done |
tal5
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play NBS songs from a certain location
Changes
at:<location>argument to specify the location the song should play fromdistance:<#>argument to control the hearing range (and volume if number < 16)autoExecute<file path>is<file_path>because it was causing a weird tab-completion issue:Notes
5or something like thatrequested by Josh65