Command Option Autocomplete Functionality #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acikek
changed the title
|
|
||
| @Override | ||
| public boolean applyDetermination(ScriptPath path, ObjectTag determination) { | ||
| if (!determination.canBeType(ListTag.class)) { |
There was a problem hiding this comment.
Not a stable check - anything can be a ListTag.
The determination should probably just be prefixed (it's intended in the future for determinations with prefixes to have native handling, so those are preferable anyway)
| // <context.focused_option> returns the name of the focused option. | ||
| // | ||
| // @Determine | ||
| // ListTag to suggest values to the Discord client. Each entry can be an ElementTag which controls both the value and display of the choice or a MapTag with "name" and "value" keys to control both separately. |
There was a problem hiding this comment.
Should document the 25 max here
src/main/java/com/denizenscript/ddiscordbot/events/DiscordCommandAutocompleteScriptEvent.java
Show resolved
Hide resolved
| List<Command.Choice> choices = new ArrayList<>(); | ||
| for (ObjectTag objectTag : list.objectForms) { | ||
| Command.Choice choice; | ||
| if (MapTag.matches(objectTag.toString())) { |
There was a problem hiding this comment.
use canBeType or shouldBeType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
discord command autocompletediscordcommandcommand options now have an optionalautocompletekey for whether they can be autocompletedNotes
discord command autocompleteanddiscord application commandevents shared the majority of their context and switches. They have been abstracted intoDiscordCommandInteractionScriptEvent.