Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

æH: shift_right_no_floor (x/2^y) atom #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

æH: shift_right_no_floor (x/2^y) atom #86

wants to merge 2 commits into from

Conversation

lynn
Copy link
Contributor

@lynn lynn commented Apr 25, 2019

No description provided.

@jjallan
Copy link
Contributor

jjallan commented Apr 26, 2019

Looks good. I'd suggest æH but don't really mind.

@lynn
Copy link
Contributor Author

lynn commented Apr 26, 2019

oh, æH is a way better name :) I just went with something that looks like ». I'll change it I think.

@lynn lynn changed the title æ⁾: shift_right_no_floor (x/2^y) atom æH: shift_right_no_floor (x/2^y) atom Apr 26, 2019
GolfingSuccess
GolfingSuccess suggested changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@GolfingSuccess GolfingSuccess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend removing the shift_right_no_floor function and replacing the call attribute with lambda number, bits: div(number, 2 ** bits, floor = False).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GolfingSuccess GolfingSuccess GolfingSuccess requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lynn @jjallan @GolfingSuccess