CMake revamp #21
Merged
CMake revamp #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at improving the cmake build. Checks for some of the third-party libraries (png, tiff, jpeg etc) and generates a config.h file. The config.h file is generated from config.h.cmake.in.
see: cmake --help-policy CMP0033 for details. Not sure yet if we need to use any export() or install(EXPORT) calls instead...
DOH. Was checking for FOUND_<libname> instead of <libname>_FOUND.
Use static inline for all of them. Portable across C++, C99, GNU89, MSVC. DevIL only so far. ILU and ILUT removed from CMakeLists.txt for now.
The issue was missing defintions of strdup() and strcasecmp(). They are not part of the c99 standard. On gcc they can be enabled by defining _GNU_SOURCE. Might be some additional work for clang.
Not quite there, but close - needs some more finessing.
|
This works for me too using kubuntu while the current does not work and errors with not being able to find ilconfig.h or something. |
This was referenced Dec 31, 2015
ILU and ILUT seem to be independent of the IL configuration (the generated config.h), so they don't need to know about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all my changes to get DevIL building and installing via CMake.
It works for me now on linux and mac, but I've not tried it on windows yet. I've been pretty careful to keep it all cross-platform, so I don't think there'll be any big issues getting it working.
There's still lots of scope for refining things, but it's at the point where I need other people to hammer on it to show up any problems.