Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deuteranopia friendly theme #286

Merged

Conversation

tejas-nagchandi
Copy link
Contributor

@tejas-nagchandi tejas-nagchandi commented Jul 28, 2022

Description

Added deuteranopia-friendly-theme.
This is inspired by #357 of github roadmap.

Intended Outcome
Users with Deuteranopia color blindness can see more colors within their visible spectrum.

Documentation
I have also updated the theme README with a screenshot of how a person with Deuteranopia will see the stats. The screenshot is taken with the help of a color blindness simulator

References #32

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

@tejas-nagchandi
Copy link
Contributor Author

No clue why Prettier task failed, the same happened with #269
This time I even made sure that the spacing is fine.
Maybe some git attribute on my local is causing this issue.

@tejas-nagchandi
Copy link
Contributor Author

@DenverCoder1 : It is because of the README update, I think it is better to have both views in the README, one with a regular user, and one with the "End User" (User with Deuteranopia)

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Jul 28, 2022

It is because of the README update

Yeah, the table column widths changed so Prettier is suggesting to increase the widths of the other rows as well. Don't worry about it. I can run the formatter to fix it.

@DenverCoder1
Copy link
Owner

Thanks for the contribution, the images seem to be a bit off-center and have some of the border cut off, you can avoid that by simply doing a right-click > copy image on the demo site and pasting it here.

I've gone ahead and tested it out so here are some images that can be used. The second is generated from the same site you mentioned.

https://user-images.githubusercontent.com/20955511/181619555-1e541bf7-9f49-47ef-8ef7-20d63e2cb712.png

image

https://user-images.githubusercontent.com/20955511/181620032-4f65c980-a48b-4270-bf56-a6747e00386a.png

image

Thanks!

@DenverCoder1
Copy link
Owner

Looks great! Thanks 👍

@DenverCoder1 DenverCoder1 merged commit af91ed6 into DenverCoder1:main Jul 29, 2022
@tejas-nagchandi tejas-nagchandi deleted the deuteranopia-friendly-theme branch July 30, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants