Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker Support and Heroku Nginx. #322

Closed
wants to merge 19 commits into from
Closed

Added Docker Support and Heroku Nginx. #322

wants to merge 19 commits into from

Conversation

nishith-p-shetty
Copy link
Contributor

Description

I have added support for docker.
You can build or use prebuilt image.
Also changed Apache2 server with Nginx server in Heroku which is up and running in my account.

Fixes # 0

Type of change

  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@nishith-p-shetty
Copy link
Contributor Author

Will it get merged......??

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-main-t3jk8byuq8cc September 9, 2022 19:08 Inactive
@DenverCoder1
Copy link
Owner

DenverCoder1 commented Sep 9, 2022

I apologize for the delay in responding.

I appreciate the effort put into this contribution.

I am having some trouble determining if the benefit is worth adding so many files for (6 added, 4 modified all at root level) since it adds a lot of clutter to the code section of the page. If it had only required changing/adding 1 or 2 files, I'd be less reluctant to merge.

I'll offer some alternatives below, but let me know if you think it is essential that all these files appear in the repo.

As an alternative, I may suggest instead adding a file to the docs folder, for example docker.md that explains the steps for setting up these files. Examples of file contents can be included. A GitHub Gist can be used if you think it would be more organized that way.

As far as the instructions in the readme, that could be moved to the docs as well, or placed in a collapsible section similar to the Heroku steps.

The Heroku nginx looks good, seems to run just fine on the review app.

Thanks, I'm happy to hear what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants