-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Docker Support and Heroku Nginx. #322
Conversation
Will it get merged......?? |
I apologize for the delay in responding. I appreciate the effort put into this contribution. I am having some trouble determining if the benefit is worth adding so many files for (6 added, 4 modified all at root level) since it adds a lot of clutter to the code section of the page. If it had only required changing/adding 1 or 2 files, I'd be less reluctant to merge. I'll offer some alternatives below, but let me know if you think it is essential that all these files appear in the repo. As an alternative, I may suggest instead adding a file to the As far as the instructions in the readme, that could be moved to the The Heroku nginx looks good, seems to run just fine on the review app. Thanks, I'm happy to hear what you think. |
Description
I have added support for docker.
You can build or use prebuilt image.
Also changed Apache2 server with Nginx server in Heroku which is up and running in my account.
Fixes # 0
Type of change
How Has This Been Tested?
composer test
Checklist:
Screenshots