Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Bangla Translations #345

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

das-amit
Copy link
Contributor

Description

This PR will introduce the required translation in Bengali

Fixes #236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Oct 26, 2022

Looks great! 👍

Could you edit the file in your branch to move bn above da so it will be in alphabetical order?

image

Also here is a preview with the locale if you can verify it looks correct:

Preview

@das-amit
Copy link
Contributor Author

@DenverCoder1 looks fine. It would be better if the font was bigger, else looks fine.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

As far as the font size, currently it is the same size for all locales. Possibly in a later PR the font scale can be made customizable per locale.

@DenverCoder1 DenverCoder1 merged commit 8a7069a into DenverCoder1:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗪 Add Translations to Streak Stats
2 participants