Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Persian (Farsi) translations #53

Merged
merged 2 commits into from
Oct 16, 2022
Merged

feat: Added Persian (Farsi) translations #53

merged 2 commits into from
Oct 16, 2022

Conversation

mehdigrn-code
Copy link
Contributor

@mehdigrn-code mehdigrn-code commented Oct 14, 2022 •
edited
Loading

Summary

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Added or updated test cases to test new features

@vercel
Copy link

vercel bot commented Oct 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ytcards ✅ Ready (Inspect) Visit Preview Oct 15, 2022 at 2:40PM (UTC)

DenverCoder1
DenverCoder1 reviewed Oct 14, 2022
View reviewed changes
api/locale/fa.yml Outdated Show resolved Hide resolved
@DenverCoder1 DenverCoder1 added the feature New feature or request label Oct 14, 2022
@mehdigrn-code @DenverCoder1
Update api/locale/fa.yml resolving RTL issue
2a46e6d 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
DenverCoder1
DenverCoder1 approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title added Persian language (Farsi) with RTL support feat: Added Persian (Farsi) translations Oct 16, 2022
@DenverCoder1 DenverCoder1 merged commit 12d706b into DenverCoder1:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehdigrn-code @DenverCoder1