Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon to web interface #79

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Conversation

MagicLike
Copy link
Contributor

@MagicLike MagicLike commented Jan 13, 2022

Description

I added an Twemoji as an icon for the web interface & updated the README with the licence attribution.

Fixes #57

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

  • Tested on own Heroku instance

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

new icon

@MagicLike
Copy link
Contributor Author

I know it's pretty simple, but I think that it could be used until a proper logo or something else is made.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Possibly we could change the name of the file from2328.png to something like favicon.png?

src/demo/index.php Outdated Show resolved Hide resolved
MagicLike and others added 2 commits January 14, 2022 14:38
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@MagicLike
Copy link
Contributor Author

Done. 👍

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 82b22fe into DenverCoder1:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a favicon
2 participants