Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(demo): Added a Reset button #167

Merged
merged 4 commits into from
Nov 13, 2022
Merged

feat(demo): Added a Reset button #167

merged 4 commits into from
Nov 13, 2022

Conversation

rajtilakjee
Copy link
Contributor

Summary

  • added button code in index.php
  • added reset code in script.js

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Have not been tested

@rajtilakjee
added RESET button
a59e0d9 
 - added button code in index.php
 - added reset code in script.js
DenverCoder1
DenverCoder1 reviewed Nov 13, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions below, feel free to let me know what you think and if you'd like you can commit them to your branch using the buttons at the bottom of the suggestions.

src/demo/js/script.js Outdated Show resolved Hide resolved
src/demo/index.php Outdated Show resolved Hide resolved
@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Nov 13, 2022
@DenverCoder1 DenverCoder1 added this to In progress in Readme Typing SVG Demo Site via automation Nov 13, 2022
@DenverCoder1 DenverCoder1 linked an issue Nov 13, 2022 that may be closed by this pull request
Need a RESET button #166
Closed
rajtilakjee and others added 2 commits November 13, 2022 13:37
@rajtilakjee @DenverCoder1
Update src/demo/js/script.js
d6cdab4 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@rajtilakjee @DenverCoder1
Update src/demo/index.php
859ed99 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@rajtilakjee
Copy link
Contributor Author

I have committed both the changed. Thank you for your suggestion and your patience. You are a very good teacher.

DenverCoder1
DenverCoder1 reviewed Nov 13, 2022
View reviewed changes
src/demo/index.php Outdated Show resolved Hide resolved
@rajtilakjee @DenverCoder1
Update src/demo/index.php
a98fe74 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@rajtilakjee
Copy link
Contributor Author

Done!

DenverCoder1
DenverCoder1 approved these changes Nov 13, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title added RESET button feat(demo): Added a Reset button Nov 13, 2022
@DenverCoder1 DenverCoder1 merged commit 831f4de into DenverCoder1:main Nov 13, 2022
Readme Typing SVG Demo Site automation moved this from In progress to Done Nov 13, 2022
@rajtilakjee rajtilakjee deleted the reset-button-added branch November 13, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Readme Typing SVG Demo Site
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a RESET button
2 participants
@rajtilakjee @DenverCoder1