Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First of all: Thank you so much for such an amazing project. Just the other day when I was working on my github profile I wanted exactly this. Sadly that day I didn't come across this amazing project and so went through the hassle of recording a typing animation -> converting it to a gif -> uploading it to my repo -> and then finally linking it in my readme. This project makes it so much easier.
This PR adds my profile to the example list, now that I switched to use this project instead of my manually created gif. You can see two occurrences of the typing animation on my profile.
Lastly I want to ask if you (@DenverCoder1) already have plans to work on this margin-bottom that is present within the generated svg. The generated text is not vertically aligned and even when reducing the total height of the svg, first the text exits the frame at the top before the space at the bottom is reduced. This made proper positioning my readme a little more stressful and I would be interested in looking into vertically aligning the text or creating the feature to control the vertical spacing around the text.
Type of change
How Has This Been Tested?
No test because just documentation update
composer test
Checklist:
Screenshots
Because of the typing animation not really showing in a screenshot, I'm omitting a screenshot. Please have a look yourself to verify that I'm using this project in my readme: https://github.com/8BitJonny