Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect upload with password #48

Closed
Yamakaky opened this issue Mar 11, 2017 · 5 comments
Closed

Protect upload with password #48

Yamakaky opened this issue Mar 11, 2017 · 5 comments
Assignees

Comments

@Yamakaky
Copy link

Do you plan to add a way to restrict the uploads, for example with a password? I have a shared server with friends and I don't want the entire internet to be able to upload files to it.

@Depado
Copy link
Owner

Depado commented Mar 13, 2017

It's pretty easy to do to add basic HTTP auth if you use a reverse-proxy in front of gpldr. What do you have in mind ? Add a password to upload the files but no password for viewing the files ?

@Yamakaky
Copy link
Author

Yeah, that's it. The client will be broken if I do that, though ?

@Depado
Copy link
Owner

Depado commented Mar 13, 2017

Yup. If you add a base HTTP Auth on your reverse proxy that would indeed break the client. But the web UI would still work fine I guess.

So what you'd like is something like that :

  • Protect the upload endpoint using a configurable password (in the conf.yml file for example)
  • Modify the client to handle this kind of authentication (in the yaml config file)

@Depado Depado self-assigned this Mar 13, 2017
@Yamakaky
Copy link
Author

Yeah, that's the idea. Nothing fancy, just to prevent random people from filling our disk.

@Depado
Copy link
Owner

Depado commented Mar 13, 2017

I'll have a look when I have some time. I'm not very active on GH lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants