Adding basic authentication for analyzer #1311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Aubry <marc.aubry@desjardins.com>
|
Thanks for the PR. I think we need to store the credentials using ConfigProperty so that we get the benefit of encryption at rest. |
|
@stevespringett humm I'm not exactly sure how it would be easily possible without doing some fairly large assumption. |
|
Hi @Marx314 , are you still working on this? |
|
@AbdelHajou not really since I didn't get any additional details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#881 might come handy.
I wasn't sure about the move of unirestGet to abstract, and the complexity level is exploding for the MavenMetaAnalyzer.
The API accept the new fields, I don't know how to update the UI.