Fix memory leak issue in vex upload processing task #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawyeok <kmter@live.com>
Closed
2 tasks
nscuro
pushed a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Jul 10, 2023
Ported from DependencyTrack/dependency-track#2873 Co-authored-by: shawyeok <kmter@live.com> Signed-off-by: nscuro <nscuro@protonmail.com>
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's a follow up PR with #2872 , there another case may cause memory leak.
In
VexUploadProcessingTask, there is aQueryManagernever get call it'sclosemethod, it could also leads memory leak.https://github.com/DependencyTrack/dependency-track/blob/master/src/main/java/org/dependencytrack/tasks/VexUploadProcessingTask.java#L62
Addressed Issue
Additional Details
Checklist