Exclude xml-apis dependency #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using java modules, it is forbidden to add classes to namespaces that are already taken by other modules. The javax.xml namespace is currently provided by the java runtime as well as the xml-apis dependency (depended on via the xercesImpl dependency). The functionality that xml-apis brings is fully provided by the runtime, making the dependency unnecessary. Eclipse is strict about this restriction and was showing corresponding errors. Exclude the xml-apis dependency while depending on xercesImpl to make eclipse happy. Signed-off-by: Hendrik Borchardt <hendrik.borchardt@gmail.com>
nscuro
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Thanks @hborchardt!
Verified that this doesn't break anything for the JAR and container image, and all looks good. But always better to double-check with these kinds of things. 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using java modules, it is forbidden to add classes to namespaces that are already taken by other modules. The javax.xml namespace is currently provided by the java runtime as well as the xml-apis dependency (depended on via the xercesImpl dependency). The functionality that xml-apis brings is fully provided by the runtime, making the dependency unnecessary.
Eclipse is strict about this restriction and was showing corresponding errors.
Exclude the xml-apis dependency while depending on xercesImpl to make eclipse happy.
Addressed Issue
Fixes #2970
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly