Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @JsonIgnore having no effect on transient fields #3051

Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 23, 2023

Description

A (more or less intentional) regression in Jackson 2.15 causes @JsonIgnore annotations on transient fields to be ignored. As a workaround, the annotation can be added to getters and setters instead (FasterXML/jackson-databind#3909 (comment)).

This regression caused multiple failures in our test suite (e.g. https://github.com/DependencyTrack/dependency-track/actions/runs/6259255825/job/16994879257).

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

A (more or less intentional) regression in Jackson 2.15 causes `@JsonIgnore` annotations on `transient` fields to be ignored. As a workaround, the annotation can be added to getters and setters instead (FasterXML/jackson-databind#3909 (comment)).

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the defect Something isn't working label Sep 23, 2023
@nscuro nscuro added this to the 4.9 milestone Sep 23, 2023
@nscuro nscuro merged commit fb28926 into DependencyTrack:master Sep 23, 2023
9 checks passed
@nscuro nscuro deleted the fix-transient-fields-jsonignore branch September 23, 2023 11:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant