-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivy #3259
Trivy #3259
Conversation
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
src/main/java/org/dependencytrack/parser/trivy/TrivyParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @fnxpt! A few necessary changes.
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/parser/trivy/TrivyParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/parser/trivy/TrivyParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/parser/trivy/model/Bitnami.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/parser/trivy/TrivyParser.java
Outdated
Show resolved
Hide resolved
69795cd
to
1557a11
Compare
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @fnxpt!
Looks good from my end, except a small resource leak and some minor logging adjustment. I have also asked other team members to test this, hoping to get even more feedback.
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/tasks/scanners/TrivyAnalysisTask.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fnxpt, I'm sure many users will appreciate this integration!
Good work @fnxpt , been following this for a while, looking forward to the release ❤️ |
Thank you so much for this feature @fnxpt! I've already been able to test the new version of the snapshot, and there's no doubt that its uses will greatly improve our security posture. Looking forward to the release! |
Description
Trivy analyser support
Addressed Issue
Closes #3251
Checklist