Expand OIDC docs #3269
Closed
Expand OIDC docs #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hosts a couple of details which aren't immediately obvious out of the Keycloak walkthrough (which I had skimmed since we don't use that IdP) and clarifies that groups must match identically including case.
acdha
force-pushed
the
expand-oidc-docs
branch
from
b6e29e0
to
487389f
Compare
|
Thanks @acdha! Could you please sign-off your commits so the DCO check passes? |
nscuro
added a commit
to nscuro/dependency-track
that referenced
this pull request
Mar 10, 2024
This hosts a couple of details which aren't immediately obvious out of the Keycloak walkthrough (which I had skimmed since we don't use that IdP) and clarifies that groups must match identically including case. Supersedes and closes DependencyTrack#3269 Co-authored-by: Chris Adams <cadams@loc.gov> Signed-off-by: nscuro <nscuro@protonmail.com>
1 task
mikael-carneholm-2-wcar
pushed a commit
to mikael-carneholm-2-wcar/dependency-track
that referenced
this pull request
Mar 15, 2024
This hosts a couple of details which aren't immediately obvious out of the Keycloak walkthrough (which I had skimmed since we don't use that IdP) and clarifies that groups must match identically including case. Supersedes and closes DependencyTrack#3269 Co-authored-by: Chris Adams <cadams@loc.gov> Signed-off-by: nscuro <nscuro@protonmail.com> Signed-off-by: Mikael Carneholm <mikael.carneholm.2@wirelesscar.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This clarifies what you have to configure when setting up OIDC authentication for DT - I had been hoping that the OpenID Connect groups list would automatically populate and missed that the group list was case-sensitive in my first test.
Addressed Issue
#3188
Additional Details
As an alternative, would it make sense to make the group to team mapping case-insensitive? Automatically populating the OIDC groups list would be a little more work since that could potentially be both large and some users might reasonably want that behaviour to be optional, but matching the group names case-insensitively should be less controversial. We have close to half a century of evidence with filesystems that distinct names differing only in case is rarely what people want.
Checklist
[ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective[ ] This PR implements an enhancement, and I have provided tests to verify that it works as intended[ ] This PR introduces changes to the database model, and I have added corresponding update logic[ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly