Fix NVD API's last modified timestamp requiring restart to be applied #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp is created with value `null` in a context where L2 caching is enabled (`DefaultObjectGenerator`), but updated in one where L2 caching is disabled (`NistApiMirrorTask#updateLastModified`). What's more, it's queried in a context with L2 caching enabled (`NistApiMirrorTask#inform`). This causes the property to be updated, but the cache not being invalidated, thus still serving queries. To not have similar inconsistencies in other areas of the application, re-enable L2 caching when updating the property. Eventually, L2 caching should be disabled system-wide. Signed-off-by: nscuro <nscuro@protonmail.com>
This was referenced Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue that caused the "last modified" timestamp for NVD mirroring via REST API to not be effective, unless the application is restarted.
Addressed Issue
#3293 (comment)
Additional Details
The timestamp is created with value
nullin a context where L2 caching is enabled (DefaultObjectGenerator), but updated in one where L2 caching is disabled (NistApiMirrorTask#updateLastModified). What's more, it's queried in a context with L2 caching enabled (NistApiMirrorTask#inform). This causes the property to be updated, but the cache not being invalidated, thus still serving queries.To not have similar inconsistencies in other areas of the application, re-enable L2 caching when updating the property.
Eventually, L2 caching should be disabled system-wide.
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly