Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align retry configuration and behavior across analyzers #3494

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 24, 2024

Description

Aligns retry configuration and behavior across analyzers:

  • Align property names
  • Retry backoff durations are now specified in milliseconds instead of seconds
  • Reduce retry attempts and retry durations for OSS Index; The previous defaults were excessive
  • Ensure that retries are only performed under certain transient error conditions, not for any error
  • Provide a common mechanism to log when retries are performed, when max attempts were exceeded, or errors were not considered for retries

Addressed Issue

Potentially relates to #2857

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Feb 24, 2024
@nscuro nscuro added this to the 4.11 milestone Feb 24, 2024
@nscuro nscuro force-pushed the align-retries branch 3 times, most recently from cbd15bf to 87729f5 Compare February 24, 2024 21:07
* Align property names
* Durations are now specified in milliseconds instead of seconds
* Reduce retry attempts and retry durations for OSS Index; The previous values were excessive
* Ensure that retries are only performed under certain transient error conditions, not for *any* error
* Provide a common mechanism to log when retries are performed, when max attempts were exceeded, or errors were not considered for retries

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro merged commit d713c2f into DependencyTrack:master Feb 24, 2024
9 checks passed
@nscuro nscuro deleted the align-retries branch February 24, 2024 22:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant