Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic API key generation for teams. Fixes part of issue #2552. #3574

Conversation

mprencipe
Copy link
Contributor

@mprencipe mprencipe commented Mar 21, 2024

Description

API keys should not be generated automatically for teams. Instead they should be generated manually when needed.

Addressed Issue

Fixes part of issue #2552.

Additional Details

Added unit test.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

…yTrack#2552.

Signed-off-by: Massimo Prencipe <mprencipe@gmail.com>
Signed-off-by: Massimo Prencipe <mprencipe@gmail.com>
@mprencipe mprencipe force-pushed the fix/2552-disable-automatic-team-apikey-generation branch from a16dab8 to 61e9140 Compare March 21, 2024 15:39
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3b52284) 21573 15971 74.03%
Head commit (61e9140) 21573 (+0) 15971 (+0) 74.03% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3574) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@nscuro nscuro added this to the 4.11 milestone Mar 22, 2024
@nscuro nscuro added the enhancement New feature or request label Mar 22, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 39615d1 into DependencyTrack:master Mar 22, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants