Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuln db severity #3595

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Vuln db severity #3595

merged 4 commits into from
Apr 10, 2024

Conversation

LaVibeX
Copy link
Contributor

@LaVibeX LaVibeX commented Apr 2, 2024

Description

Severity not added to VulnDB vulnerabilities. use setSeverity to fix this issue.

Addressed Issue

Fixes #3589

Additional Details

Add an explicit null check and a Logger WARN message in case Vulnerability Severity is null.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Apparently the severity was never added to those vulnerabilities.
use setSeverity to fix this issue.

Signed-off-by: Andres Tito <andres.tito@rohde-schwarz.com>
Signed-off-by: Andres Tito <andres.tito@rohde-schwarz.com>
@nscuro nscuro added this to the 4.11 milestone Apr 2, 2024
@nscuro nscuro added the defect Something isn't working label Apr 2, 2024
Copy link

codacy-production bot commented Apr 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 71.43% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1607040) 21649 16120 74.46%
Head commit (d1753a6) 21657 (+8) 16127 (+7) 74.47% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3595) 14 10 71.43%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@LaVibeX LaVibeX requested a review from nscuro April 3, 2024 13:18
Signed-off-by: Andres Tito <andres.tito@rohde-schwarz.com>
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LaVibeX!

@nscuro nscuro added the integration/vulndb Related to the VulnDB integration label Apr 10, 2024
@nscuro nscuro merged commit 458ca3a into DependencyTrack:master Apr 10, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working integration/vulndb Related to the VulnDB integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VulnDB Vulnerabilities Always Shown as Unassigned Severity
2 participants