Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all unhandled ClientErrorExceptions #3659

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Apr 29, 2024

Description

Catches all unhandled ClientErrorExceptions.

ClientErrorException in JAX-RS corresponds to HTTP 4xx status codes. Those were previously handled by Alpine's GlobalExceptionHandler, resulting in an HTTP 500 response when it really should've been a 4xx.

Addressed Issue

Fixes #3645

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the defect Something isn't working label Apr 29, 2024
@nscuro nscuro added this to the 4.11 milestone Apr 29, 2024
`ClientErrorException` in JAX-RS corresponds to HTTP 4xx status codes. Those were previously handled by Alpine's `GlobalExceptionHandler`, resulting in an HTTP 500 response when it really should've been a 4xx.

Fixes DependencyTrack#3645

Signed-off-by: nscuro <nscuro@protonmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for f4008f21 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f4008f2) Report Missing Report Missing Report Missing
Head commit (6538d25) 22054 16497 74.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3659) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@nscuro nscuro merged commit 664ee25 into DependencyTrack:master Apr 30, 2024
11 checks passed
@nscuro nscuro deleted the issue-3645 branch April 30, 2024 08:01
@nscuro nscuro mentioned this pull request May 18, 2024
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API returns 500 Internal Server Error instead of 405
1 participant