Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BomUploadProcessingTaskTest #3676

Merged
merged 1 commit into from
May 6, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 6, 2024

Description

Simplifies BomUploadProcessingTaskTest:

  • Removes redundant bomUploadProcessingTaskSupplier, since the choice which task to run is now made via ConfigProperty
  • Fixes string equality checks when comparing the task name

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

* Remove redundant `bomUploadProcessingTaskSupplier`, since the choice which task to run is now made via `ConfigProperty`
* Fix string equality checks when comparing the task name

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added this to the 4.11 milestone May 6, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4683325) 22069 16756 75.93%
Head commit (c946e59) 22069 (+0) 16756 (+0) 75.93% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3676) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit b3cca4d into DependencyTrack:master May 6, 2024
12 checks passed
@nscuro nscuro deleted the simplify-test branch May 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant