-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix os handling when trivy sets pkgType on properties #3727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fnxpt! Could you add a test for this in TrivyAnalysisTaskIntegrationTest
?
Please rebase the PR with |
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
rebase seems to have worked, I will add the test later |
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
@nscuro Test added |
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Signed-off-by: Marlon Pina Tojal <marlont@backbase.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fnxpt for the super fast debugging and fix!
Description
Handles PkgType trivy property
Addressed Issue
Fixes #3721
Checklist