Refactor finding detail and fix finding search routes #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykter
commented
Dec 26, 2023
| @@ -11,6 +11,7 @@ module.exports = { | |||
| proxy: { "/api": { target: process.env.VUE_APP_SERVER_URL} } | |||
| }, | |||
| configureWebpack: { | |||
| devtool: 'source-map', | |||
There was a problem hiding this comment.
This is a drive-by improvement from the docs, which I used to make debugging easier.
mykter
force-pushed
the
finding-audit-route
branch
2 times, most recently
from
e9d0705
to
0b2e876
Compare
mykter
changed the title
mykter
force-pushed
the
finding-audit-route
branch
2 times, most recently
from
2c199ca
to
d42e6a8
Compare
mykter
commented
Dec 28, 2023
| @@ -132,7 +132,7 @@ function configRoutes() { | |||
| }, | |||
| { | |||
| path: 'projects/:uuid/findings/:vulnerability', | |||
| name: 'Project Finding Lookup', | |||
| name: 'Project Vulnerability Lookup', | |||
There was a problem hiding this comment.
I noticed this existing name clash because vue-router was complaining about it in the console.
mykter
commented
Dec 28, 2023
| @@ -0,0 +1,247 @@ | |||
| <template> | |||
Signed-off-by: mykter <git@mykter.com>
Signed-off-by: mykter <git@mykter.com>
Signed-off-by: mykter <git@mykter.com>
Signed-off-by: mykter <git@mykter.com>
mykter
force-pushed
the
finding-audit-route
branch
from
edfcded
to
cec631b
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a pair of bugs and factors out the finding detail view into its own single file component.
It might be easiest to review commit by commit.
Addressed Issue
Fixes #688 in 3895307
Additional Details
I originally planned to make a new view to show a specific finding, and wanted to re-use the detail view from the audit page. This was inlined in a way that was very hard to re-use (or read!). In my journey to try and re-use it I came across Steve's earlier investigations, and was eventually able to pull it out into its own component as it looks like he originally wanted to.
I then discovered that there is already a route that shows this information, it just doesn't work.
I think the refactoring is still worthwhile by itself - maintaining this view in SFC form is easier than in the inline form. The refactoring allowed eslint to find some issues in the inlined code, for example.
Checklist