fix: correctly calculate audited violations and audited findings percentages #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setchy
force-pushed
the
fix/audited-violations-percentage
branch
from
3d4eb1b
to
28c4f18
Compare
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
force-pushed
the
fix/audited-violations-percentage
branch
from
080e69d
to
5e5a004
Compare
setchy
changed the title
nscuro
approved these changes
Jan 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Audited Violations Percentage and Audited Findings Percentage were being incorrectly calculated due to a typo.
Addressed Issue
Uses the correct properties to calculate the percentages
Additional Details
Using mocked data
Before
After
Checklist