Aliases column is not displaying information in Vulnerabilities section #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @LaVibeX! Looks like there's a merge conflict here, do you mind resolving it? |
common.resolveVulnALiases needs the vulnerability source and the aliases to deduplicate the list on the Aliases column, In case before, the only parameter added to the function was "value" which do not include neither the source of the current vulnerability or their aliases. Thats why I am adding row.source and row.aliases to the function. I discovered that the 'return' statement was located within the condition if(typeof value !== 'undefined'), This created a problem because the function would not return anything for null values. To fix this, I moved the 'return' outside of the condition. Signed-off-by: Andres Tito <andres.tito@rohde-schwarz.com>
…ource and value to the resolveVulnAliases function and it will have same results. No difference in taking the "return label" outside or inside the if condition, no changes required. Run prettier. Signed-off-by: Andres Tito <andres.tito@rohde-schwarz.com>
|
Hi @nscuro conflict was resolved 👍 |
nscuro
approved these changes
Mar 14, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Neccesary parameter to resolveVulnAliases function
common.resolveVulnALiases needs the vulnerability source and the aliases to deduplicate the list on the Aliases column,
The only parameter added to the function was "value" which do not include neither the source of the current vulnerability or their aliases.
Thats why I am adding row.source and row.aliases to the function.
I discovered that the 'return' statement was located within the condition if(typeof value !== 'undefined'), This created a problem because the function would not return anything for null values. To fix this, I moved the 'return' outside of the condition.
Addressed Issue
#765
Additional Details
Checklist