Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): add internal / external classification badge #776

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Mar 13, 2024

Description

Add an internal or external badge to the component view and component details model.

I'd appreciate feedback/input on the correct terminology to use for this. I went with component_source for this PR, but was also contemplating component_scope

Addressed Issue

Previously, there was no way through the UI to determine if a component was internal or external

Additional Details

Screenshot 2024-03-13 at 6 36 49 AM
Screenshot 2024-03-13 at 6 36 58 AM

Checklist

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Copy link
Contributor Author

setchy commented Mar 22, 2024

@nscuro - do you happen to have any feedback on this enhancement suggestion?

@nscuro
Copy link
Member

nscuro commented Mar 22, 2024

@setchy Thanks for the ping! I like the idea of having this badge. But I am also not super sure about the label name. 🤔

We need to be cautious to not use terms that could be confused with provenance, which I think would be the case for component source. Similar story for component origin for example.

[...] but was also contemplating component_scope

Scope might be confused with component.scope in the spec, which to be fair, DT currently does not display.

How about classification? Similar to how a business would classify documents as confidential or not. In our case, components would be classified as either internal or external.

@setchy
Copy link
Contributor Author

setchy commented Mar 22, 2024

Exactly the type of feedback I needed! Really like the suggestion to use Classification. Will update asap

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Copy link
Contributor Author

setchy commented Mar 22, 2024

Updated terminology to use Classification

@setchy setchy changed the title feat(component): add badge to show internal / external details feat(component): add internal / external classification badge Mar 22, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro added this to the 4.11 milestone Mar 22, 2024
@nscuro nscuro added the enhancement New feature or request label Mar 22, 2024
@nscuro nscuro merged commit 3b9f27c into DependencyTrack:master Mar 22, 2024
10 checks passed
@setchy setchy deleted the feature/component-view-internal-external-badge branch March 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants